Update string resource #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ai-agent-messenger-sample canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates string resources in the Android application, primarily focusing on improving conversation-related UI text and adding new localization strings.
- Updates conversation-related text labels for better clarity
- Removes unused conversation action strings
- Adds new UI elements for conversation status, timestamps, and agent interaction
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <string name="aa_text_csat_submit">Submit</string> | ||
| <string name="aa_text_csat_dialog_edittext_hint"> Share your feedback</string> | ||
| <string name="aa_text_csat_notice_conversation_closed">Your conversation has ended.</string> | ||
| <string name="aa_text_csat_notice_conversation_closed">This conversation has ended.</string> |
There was a problem hiding this comment.
[nitpick] The change from 'Your conversation has ended' to 'This conversation has ended' appears subtle but could impact user experience. Consider whether this change maintains consistency with other user-facing messages in the application.
Suggested change
| <string name="aa_text_csat_notice_conversation_closed">This conversation has ended.</string> | |
| <string name="aa_text_csat_notice_conversation_closed">Your conversation has ended.</string> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.